search

ashfurrow / ARCollectionViewMasonryLayout

MIT License
185 stars 16 forks source link

@orta => rename some methods and variables for clarity #15

Closed 1aurabrown closed 10 years ago

1aurabrown commented 10 years ago

More meaningful changes coming. Laying some groundwork by making the naming more clear. Here, as in eigen, we were using words like 'length' and 'width' to sometimes refer to the opposite of what the words imply, depending on the orientation.

ashfurrow commented 10 years ago

This looks cool so far. Let me know when you want it merged.

orta commented 10 years ago

this contain API breakages, we'll have to do a full version bump on the next semver

1aurabrown commented 10 years ago

the only thing i changed in the api in this PR is the local variable names for parameters in a method. Shouldn't be breaking. My other PR, on the other hand, removes the two optional methods from the masonry layout delegate protocol.

1aurabrown commented 10 years ago

@AshFurrow travis is having problems today as you've noticed, if you feel ok merging, go ahead.

ashfurrow commented 10 years ago

Looks like Travis' pod install failed?

1aurabrown commented 10 years ago

this time, the simulator apparently timed out. however pod install succeeded. pushing again.

1aurabrown commented 10 years ago

@AshFurrow woohoo this finally passed!