search

ashfurrow / ARCollectionViewMasonryLayout

MIT License
185 stars 16 forks source link

@ashfurrow => remove header and footer attributes if header/footer has no size #22

Closed 1aurabrown closed 9 years ago

1aurabrown commented 9 years ago

I noticed that in our favorites view, when using the masonry layout, the collection view's footer wasn't disappearing when it should (after all items have been fetch) because our layout was still returning the old footer's attributes. This fixes that.

ashfurrow commented 9 years ago

Looks like the build error'd because it couldn't find the gem – likely due to the DNS outages a few days ago. I've restarted.

ashfurrow commented 9 years ago

Looks like pod install is failing – can you take a look @1aurabrown ?

orta commented 9 years ago

just needs a pod update, as the older ARCollectionViewMasonryLayout version in the .lock

ashfurrow commented 9 years ago

Weird – I thought that when using :path, CocoaPods ignores the lock file.

orta commented 9 years ago

nooooppee unless it was fixed in 0.35 ( /cc @segiddins )

ashfurrow commented 9 years ago

1aurabrown commented 9 years ago

totallymsised this conversation, will fix!

ashfurrow commented 9 years ago

:-1:

ashfurrow commented 9 years ago

Ah! Sorry! That was supposed to be :+1:

1aurabrown commented 9 years ago

@ashfurrow it's green :+1:

1aurabrown commented 9 years ago

i'm mergin