ashfurrow / Nimble-Snapshots

Nimble matchers for FBSnapshotTestCase.
https://medium.com/cocoaacademymag/unit-testing-uiview-with-nimble-snapshot-651a7c5a5e93
MIT License
319 stars 102 forks source link

Bump version to 9.2.0 #234

Closed dogo closed 3 years ago

dogo commented 3 years ago

@ashfurrow Just need to add the tag and make the CocoaPods publication. Address #233

ashfurrow commented 3 years ago

Okay, this is tagged 9.2.0 on GitHub but I ran into a problem when trying to publish the CocoaPod:

> pod trunk push --allow-warnings --skip-import-validation
Validating podspec
 -> Nimble-Snapshots (9.2.0)
    - ERROR | [Nimble-Snapshots/Core, Nimble-Snapshots/DynamicType, Nimble-Snapshots/DynamicSize, and more...] xcodebuild: Returned an unsuccessful exit code. You can use `--verbose` for more information.
    - NOTE  | [Nimble-Snapshots/Core, Nimble-Snapshots/DynamicType, Nimble-Snapshots/DynamicSize, and more...] xcodebuild:  note: Using new build system
    - NOTE  | [Nimble-Snapshots/Core, Nimble-Snapshots/DynamicType, Nimble-Snapshots/DynamicSize, and more...] xcodebuild:  note: Using codesigning identity override: -
    - NOTE  | [Nimble-Snapshots/Core, Nimble-Snapshots/DynamicType, Nimble-Snapshots/DynamicSize, and more...] xcodebuild:  note: Build preparation complete
    - NOTE  | [Nimble-Snapshots/Core, Nimble-Snapshots/DynamicType, Nimble-Snapshots/DynamicSize, and more...] xcodebuild:  note: Planning
    - NOTE  | [Nimble-Snapshots/Core, Nimble-Snapshots/DynamicType, Nimble-Snapshots/DynamicSize, and more...] xcodebuild:  note: Building targets in parallel
    - NOTE  | [Nimble-Snapshots/Core, Nimble-Snapshots/DynamicType, Nimble-Snapshots/DynamicSize, and more...] xcodebuild:  warning: Skipping code signing because the target does not have an Info.plist file and one is not being generated automatically. (in target 'Nimble-Snapshots' from project 'Pods')
    - ERROR | [Nimble-Snapshots/Core, Nimble-Snapshots/DynamicType, Nimble-Snapshots/DynamicSize, and more...] xcodebuild:  iOSSnapshotTestCase/FBSnapshotTestCase/Categories/UIImage+Snapshot.m:49:34: error: 'sharedApplication' is unavailable: not available on iOS (App Extension) - Use view controller based solutions where appropriate instead.
    - NOTE  | [Nimble-Snapshots/Core, Nimble-Snapshots/DynamicType, Nimble-Snapshots/DynamicSize, and more...] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator15.0.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIApplication.h:114:54: note: property 'sharedApplication' is declared unavailable here
    - NOTE  | [Nimble-Snapshots/Core, Nimble-Snapshots/DynamicType, Nimble-Snapshots/DynamicSize, and more...] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator15.0.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIApplication.h:114:54: note: 'sharedApplication' has been explicitly marked unavailable here
    - NOTE  | [Nimble-Snapshots/Core, Nimble-Snapshots/DynamicType, Nimble-Snapshots/DynamicSize, and more...] xcodebuild:  warning: Skipping code signing because the target does not have an Info.plist file and one is not being generated automatically. (in target 'Nimble' from project 'Pods')
    - NOTE  | [Nimble-Snapshots/Core, Nimble-Snapshots/DynamicType, Nimble-Snapshots/DynamicSize, and more...] xcodebuild:  warning: Skipping code signing because the target does not have an Info.plist file and one is not being generated automatically. (in target 'iOSSnapshotTestCase' from project 'Pods')
    - NOTE  | [Nimble-Snapshots/Core, Nimble-Snapshots/DynamicType, Nimble-Snapshots/DynamicSize, and more...] xcodebuild:  <unknown>:0: error: unable to load standard library for target 'arm64-apple-ios9.0'
    - ERROR | [Nimble-Snapshots/Core, Nimble-Snapshots/DynamicType, Nimble-Snapshots/DynamicSize, and more...] xcodebuild:  iOSSnapshotTestCase/FBSnapshotTestCase/Categories/UIImage+Snapshot.m:49:34: error: 'sharedApplication' is unavailable: not available on tvOS (App Extension) - Use view controller based solutions where appropriate instead.
    - NOTE  | [Nimble-Snapshots/Core, Nimble-Snapshots/DynamicType, Nimble-Snapshots/DynamicSize, and more...] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/AppleTVSimulator.platform/Developer/SDKs/AppleTVSimulator15.0.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIApplication.h:114:54: note: property 'sharedApplication' is declared unavailable here
    - NOTE  | [Nimble-Snapshots/Core, Nimble-Snapshots/DynamicType, Nimble-Snapshots/DynamicSize, and more...] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/AppleTVSimulator.platform/Developer/SDKs/AppleTVSimulator15.0.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIApplication.h:114:54: note: 'sharedApplication' has been explicitly marked unavailable here

The important error is:

error: 'sharedApplication' is unavailable: not available on tvOS (App Extension) - Use view controller based solutions where appropriate instead.

I'd like to dig into this further but don't have time this week. I'll open an issue to track.

@dogo I've been really grateful for your work on this repo and I've added you as an owner to the CocoaPod on trunk, so you should be able to publish a new version. If you want! No pressure at all – but I didn't want this to block you. Hope you're well, and take care 🙏