search

ashfurrow / Nimble-Snapshots

Nimble matchers for FBSnapshotTestCase.
https://medium.com/cocoaacademymag/unit-testing-uiview-with-nimble-snapshot-651a7c5a5e93
MIT License
317 stars 101 forks source link

Fix Swift Package definition #255

Closed diogot closed 1 year ago

diogot commented 1 year ago

The update to Nimble 11 something had broking in the Package configuration, I fixed it and also update to new syntax to avoid deprecation warnings.

diogot commented 1 year ago

Don't worry, I use Swift daily but never write package descriptions too, hehe. Did I messed up something that make Danger fail?

ashfurrow commented 1 year ago

Nah it's probably unrelated – probably a permission thing running from a fork. Merging 👍

ashfurrow commented 1 year ago

Oh wait, Danger failed before the tests got ran. Let me run them locally. Danger should be configured to run last to avoid this.

ashfurrow commented 1 year ago

Okay! So tests are failing, but they're failing on master too 😬😅 I've opened #257 to investigate. In the meantime, I'm going to merge. Let me know if we should release a new version of the library.

ashfurrow-peril[bot] commented 1 year ago

Thanks a lot for contributing @diogot! You've been invited to be a collaborator on this repo – no pressure to accept! If you'd like more information on what this means, check out the Moya contributor guidelines and feel free to reach out with any questions.

Generated by :no_entry_sign: dangerJS

diogot commented 1 year ago

Hi, sorry for the delay, too many things happening. I checked and we need a new release.

diogot commented 1 year ago

Is this (create a new release) something that I can do?

ashfurrow commented 1 year ago

Unfortunately, I need to do it because releasing involves both pushing a tag to GitHub and a CocoaPods podspec. I know this is an SPM-only change but I want to keep them in lockstep.

I've pushed up this change in version 9.5.1 and the podspec is pushing now. You should be good to go, let me know 👍 Thanks for your patience on this – I've had a death in the family recently and open source hasn't been a priority for me.

diogot commented 1 year ago

I'm sorry for you loss 😔

Regarding the release everything is working great, and thank you very much for been so helpful!