search

ashfurrow / Nimble-Snapshots

Nimble matchers for FBSnapshotTestCase.
https://medium.com/cocoaacademymag/unit-testing-uiview-with-nimble-snapshot-651a7c5a5e93
MIT License
319 stars 102 forks source link

Test in light and dark mode #265

Open dchohfi opened 1 year ago

dchohfi commented 1 year ago

Hi 👋

It is a pleasure to be able to open a PR in this lib, I've been using this for years and years, thank you for creating and supporting it!

I had to add a support for light/dark mode on a private app and thought about opening a PR, lets see if you think this worth to be merged on the main code.

Hopefully I did everything (almost) correct 🙏

FYI: my last commit - 3fb008d52fbaf39d578e7b1e683bd207c597b983 - tries to add a test that wasn't added to the project, and I don't know why it isn't recording snapshots, I might need some help with it.

Anyway, let me know how can I improve this PR and if it makes sense to be added to the main code.

ashfurrow commented 1 year ago

Hey this looks cool! Apologies for not reviewing sooner, things have been hectic. I probably won't get a chance to review this until later this week. Thanks the PR and for your patience 🙏

dchohfi commented 1 year ago

hey @ashfurrow no problem! we're using internally our own fork for now.

let me know when you have time, thank you.