search

ashfurrow / danger-ruby-swiftlint

A Danger plugin for SwiftLint.
https://rubygems.org/gems/danger-swiftlint
MIT License
203 stars 81 forks source link

Add a #strict option which fails on errors AND warnings #128

Closed imownbey closed 5 years ago

imownbey commented 5 years ago

I wanted to make errors and issues accessible so that they can be introspected in the Dangerfile if needed. I also needed an option similar to the commandline option --strict which fails on any warnings or errors. Right now just passing in strict in additional_swiftlint_args doesn't work because we don't look at the status of Swiftlint to see if we should fail or not, we just look to see if there are errors. additional_swiftlint_args makes the command fail, but doesn't change warnings to errors.

ashfurrow commented 5 years ago

Okay, that's on RubyGems as 0.20.1. Thanks again for your contribution!

imownbey commented 5 years ago

Thank you!