search

ashfurrow / danger-ruby-swiftlint

A Danger plugin for SwiftLint.
https://rubygems.org/gems/danger-swiftlint
MIT License
203 stars 81 forks source link

[Question] How do I tell what version of SwiftLint danger is running? #137

Open bdrelling opened 5 years ago

bdrelling commented 5 years ago

In addition to the question in the title, if I want Danger to pull in and run a specific version of SwiftLint, is there any way to do so?

I keep getting this error that unused_declaration isn't a rule... but it's been in SwiftLint for a few releases now and hasn't gone away. I'm not sure why it keeps spitting that error out at me.

These are my Danger dependencies in my Gemfile:

gem 'danger', '~> 6.1.0'
gem 'danger-junit', '~> 1.0.0'
gem 'danger-rubocop', '~> 0.7.0'
gem 'danger-swiftlint', '~> 0.23.0'

Speaking of which, there's no 0.23.0 tag on GitHub?

ashfurrow commented 5 years ago

Hi, thanks! I've created that tag, thank you 😅 As for the version, you can install swiftlint yourself and point the plugin to it using the binary_path configuration option, but by default SwiftLint will be installed during bundle install according to the version specified here:

https://github.com/ashfurrow/danger-ruby-swiftlint/blob/d12ff5cb4ff4d9fb1bcd96b2ee7e0ff9e9cbb5a2/lib/version.rb#L5

Hope that answers your question, let me know what I can clarify 👍