Closed austinwright closed 4 years ago
Danger normally edits/deletes comments on subsequent runs, so the comments are always up-to-date. I would bet that strikethrough is a feature of Danger's that is only used on inline comments. I'm not sure – I don't use the inline comment feature.
Hmm, looks like you're right: https://github.com/danger/danger/issues/1189
Though when browsing the diff between the latest release and 6.2.0 nothing stuck out as being the root cause of this odd behavior 🤔 . I will comment on that issue to try and gain some additional traction.
I'll note that the creator of Danger tends not to use inline comments either, so it might be worth seeking out developers who implemented it and asking for advice.
Hi, I'm seeing this on my inline swiftlint errors and warnings after a successful CI run with danger and danger-ruby-swiftlint. The plain Danger warning does not appear with strikethrough. It happens on PR open and re-open. (Note I have been using the same test branch for debugging the CI workflow and there are several closed PRs - could this be the issue?).
Versions: danger:
danger (6.3.1)
danger-swiftlint:danger-swiftlint (0.24.2)
Screenshots:
Inline SwiftLint violation:
Normal Danger comment: