search

ashfurrow / danger-ruby-swiftlint

A Danger plugin for SwiftLint.
https://rubygems.org/gems/danger-swiftlint
MIT License
203 stars 81 forks source link

Inline Swiftlint comments are crossed out #145

Closed austinwright closed 4 years ago

austinwright commented 4 years ago

Hi, I'm seeing this on my inline swiftlint errors and warnings after a successful CI run with danger and danger-ruby-swiftlint. The plain Danger warning does not appear with strikethrough. It happens on PR open and re-open. (Note I have been using the same test branch for debugging the CI workflow and there are several closed PRs - could this be the issue?).

Versions: danger: danger (6.3.1) danger-swiftlint: danger-swiftlint (0.24.2)

Screenshots:

Inline SwiftLint violation:

Screen Shot 2020-03-11 at 4 52 03 PM

Normal Danger comment:

Screen Shot 2020-03-11 at 4 56 40 PM
ashfurrow commented 4 years ago

Danger normally edits/deletes comments on subsequent runs, so the comments are always up-to-date. I would bet that strikethrough is a feature of Danger's that is only used on inline comments. I'm not sure – I don't use the inline comment feature.

austinwright commented 4 years ago

Hmm, looks like you're right: https://github.com/danger/danger/issues/1189

Though when browsing the diff between the latest release and 6.2.0 nothing stuck out as being the root cause of this odd behavior 🤔 . I will comment on that issue to try and gain some additional traction.

ashfurrow commented 4 years ago

I'll note that the creator of Danger tends not to use inline comments either, so it might be worth seeking out developers who implemented it and asking for advice.