search

ashfurrow / danger-ruby-swiftlint

A Danger plugin for SwiftLint.
https://rubygems.org/gems/danger-swiftlint
MIT License
203 stars 81 forks source link

--strict mode not working, even with via `additional_swiftlint_args` #151

Open Jeehut opened 4 years ago

Jeehut commented 4 years ago

I just wanted to setup swiftlint via danger using this gem, but when I specify the additional_swiftlint_args: '--strict' as implemented in #59, nothing actually changes, still all warnings show up as warnings and danger doesn't fail, although I have setup both fail_on_error: true on this gem and even --fail-on-errors=true on danger itself. Even setting max_num_violations to 0 doesn't fail if there's only a warning. So basically there seems to be no way to make the CI fail on warnings as of now. 😞

Note that the --strict parameter does not convert warnings to errors, instead it just ensures the overall swiftlint command fails by returning with a non zero status code (see this comment). That's probably why --strict is doing nothing ...

ashfurrow commented 4 years ago

I see, thanks for opening the issue. Can you show how you're invoking this in the Dangerfile? Along with a version number for Danger, the plugin, and Ruby would be helpful 👍

quintuschen commented 3 years ago

I have the same problem. I wrote like the following in Dangerfile:

swiftlint.lint_files inline_mode: true, fail_on_error: true, additional_swiftlint_args: '--strict'
Wooder commented 2 years ago

Has anyone found a (maybe temporary) solution of the problem in the meantime?

quangpc commented 2 years ago

I have same issue. Did anyone find the solution for this problem? Thank you.