search

ashfurrow / danger-ruby-swiftlint

A Danger plugin for SwiftLint.
https://rubygems.org/gems/danger-swiftlint
MIT License
203 stars 80 forks source link

Don’t pass explicit config if lint_all_files: true #154

Closed marcelofabri closed 3 years ago

marcelofabri commented 3 years ago

SwiftLint 0.41.0 introduces a breaking change when handling —config and nested configs: https://github.com/realm/SwiftLint/issues/3417

I've only changed the behavior when lint_all_files = true to be more cautious - SwiftLint's config handling is a landmine and I'm afraid of breaking something when linting individual files

marcelofabri commented 3 years ago

LGTM

Thanks for the quick review! Can you please merge it and create a release? Happy to do it as well if you give me permission to the repo and RubyGems 🙏

thii commented 3 years ago

Oops sorry merging now.

ashfurrow-peril[bot] commented 3 years ago

Thanks a lot for contributing @marcelofabri! You've been invited to be a collaborator on this repo – no pressure to accept! If you'd like more information on what this means, check out the Moya contributor guidelines and feel free to reach out with any questions.

Generated by :no_entry_sign: dangerJS

thii commented 3 years ago

It's released now https://rubygems.org/gems/danger-swiftlint/versions/0.24.5.

mokagio commented 3 years ago

🎉 Thanks!