search

ashfurrow / danger-ruby-swiftlint

A Danger plugin for SwiftLint.
https://rubygems.org/gems/danger-swiftlint
MIT License
203 stars 81 forks source link

Improved `config-file` handling to match SwiftLint's expected behavior. #161

Closed dirtyhabits97 closed 3 years ago

dirtyhabits97 commented 3 years ago

This fixes #160 by not providing a default config_file. Instead it lets SwiftLint handle unspecified config files.

Users that explicitly provided a config_file should not see any changes.

dirtyhabits97 commented 3 years ago

@ashfurrow I deleted a test that should no longer apply now that the plugin doesn't provide a default config file. Lmk if this is the correct approach.

dirtyhabits97 commented 3 years ago

Yes, when I provide a config file

swiftlint.config_file = '.swiftlint.yml'

It ignores the config files in the subdirectories.

When I don't provide a config file the nested configs work as expected.

ashfurrow-peril[bot] commented 3 years ago

Thanks a lot for contributing @dirtyhabits97! You've been invited to be a collaborator on this repo – no pressure to accept! If you'd like more information on what this means, check out the Moya contributor guidelines and feel free to reach out with any questions.

Generated by :no_entry_sign: dangerJS

ashfurrow commented 3 years ago

Okay awesome! That's been merged and released to Ruby Gems as version 0.26.0. Thanks again for the suggestion – please do open issues/PRs for further ideas you might have!