Closed rogerluan closed 3 years ago
Thanks for your support @mokagio ! ❤️
I haven't had much time to invest on open source contributions lately, but I'll come back to this PR soon if I have the spare time. Meanwhile, if anyone feel like writing those unit tests, I'd be happy to review them when I can 🙏
I'll take a look at the tests, given that this also solves a problem i'm hitting.
Sidenote...When I run rake spec
I have 12 failing tests, however, all the checks have passed. I noticed travis is no longer running the tests for our PRs, is this intentional @ashfurrow ?
Also, I think fixing the original tests should be enough to test this fix, what do you think? @mokagio
EDIT: I just saw this message in travis Since June 15th, 2021, the building on travis-ci.org is ceased. Please use travis-ci.com from now on.
So we might have to migrate our CI?
Ended up fixing the previous tests and added a couple dedicated to this fix / feature.
Let me know if I can help with something else.
Thanks a lot for contributing @rogerluan! You've been invited to be a collaborator on this repo – no pressure to accept! If you'd like more information on what this means, check out the Moya contributor guidelines and feel free to reach out with any questions.
Generated by :no_entry_sign: dangerJS
This has bene released in version 0.28.0. Thanks again!
Description
Resolves #168
I shamelessly copied the strategy implemented by a similar linter: https://github.com/garriguv/danger-ruby-swiftformat/blob/8915b65a9b17d26c80cd9c5caa08cb3cf2bafefa/lib/swiftformat/plugin.rb#L82-L87
Tested on my project by pointing my Gemfile to my local clone and it works perfectly 💪