search

ashfurrow / danger-ruby-swiftlint

A Danger plugin for SwiftLint.
https://rubygems.org/gems/danger-swiftlint
MIT License
203 stars 80 forks source link

Fix `Command failed with status 127` (#162) #173

Closed NicolasCombe5555 closed 3 years ago

NicolasCombe5555 commented 3 years ago

Same issue -> #172 Sorry again, not sure why when I test it against my fork it works but when we released 0.29.1 it was not. Anyway I believe 🙏🏻 this will fix it.

ashfurrow commented 3 years ago

I've released this as 0.29.2, whenever you have a chance to test 👍

NicolasCombe5555 commented 3 years ago

So still an error but this is weird, when running bundle update danger-swiftlint. The script is not inside ~/ext/swiftlint.

Screen Shot 2021-09-07 at 14 19 56

I went to that path and the file is not even there.

Screen Shot 2021-09-07 at 14 22 55

Do we need to do like an extra step here?

ashfurrow commented 3 years ago

Wow! Weird, I don't see it in the generated .gem file either.

OH okay I see the problem. The download script is a .sh file, but only .rb files are included in the gemspec. That would explain why it works locally. I'll push a change now to fix 👍

ashfurrow commented 3 years ago

That should be fixed here:

https://github.com/ashfurrow/danger-ruby-swiftlint/commit/0b9223cb2eef48beead03784d0e655e2288bc9e4#diff-c0aa4fa469ac733041252c4ce300c3dbddcbd911efac82f5e0198efd2231e5e1R17

That was released in 0.29.3. Sorry for all the turnaround here!

NicolasCombe5555 commented 3 years ago

It works now 🎉

Screen Shot 2021-09-07 at 14 38 10

Thank you and sorry again 😅

ashfurrow commented 3 years ago

Yay! Thanks for verifying 👍