Don't rely on the swiftlint executable for tests.

ashfurrow / danger-ruby-swiftlint

A Danger plugin for SwiftLint.

https://rubygems.org/gems/danger-swiftlint

MIT License

203 stars 80 forks source link

Don't rely on the swiftlint executable for tests. #174

Closed dirtyhabits97 closed 3 years ago

dirtyhabits97 commented 3 years ago

CI is raising this error

expected no Exception, got #<Errno::ENOENT: No such file or directory - /home/travis/build/ashfurrow/danger-ruby-swiftlint/ext/swiftlint/bin/swiftlint> with backtrace:

It seems like it is trying to find the swiftlint executable to lint the renamed file. This line fixes it:

allow_any_instance_of(Swiftlint).to receive(:lint).and_return('')

Fixes #171

dirtyhabits97 commented 3 years ago

The downloadSwiftlint.sh now works on linux too. Works as expected on mac:

ashfurrow commented 2 years ago

Since this fixes a problem on Linux, I've released this as version 0.29.4. Thanks again!