Update SwiftLint version to 0.46.2

ashfurrow / danger-ruby-swiftlint

A Danger plugin for SwiftLint.

https://rubygems.org/gems/danger-swiftlint

MIT License

203 stars 80 forks source link

Update SwiftLint version to 0.46.2 #176

Closed mvandervelden closed 2 years ago

mvandervelden commented 2 years ago

As the SwiftLint version used by the plugin got outdated, it started introducing discrepancies between our local builds and the report from Danger. (we would fix a warning locally, but it still pops up in Danger because of an older version of the rule).

I think it's warranted to update the swiftlint version as opposed to manually inject the SWIFTLINT_VERSION env var for a version more recent than the plugin.

I'm of course open to suggestions, in case anything else also needs changes to make this work 😅.

Kaspik commented 2 years ago

@ashfurrow Pretty please! 🙏🏼

ashfurrow commented 2 years ago

(Thank you for the PR, by the way! I’ve been distracted lately so my review times are slower than I’d like, but I always appreciate the work that others contribute 🙏)

ashfurrow-peril[bot] commented 2 years ago

Thanks a lot for contributing @mvandervelden! You've been invited to be a collaborator on this repo – no pressure to accept! If you'd like more information on what this means, check out the Moya contributor guidelines and feel free to reach out with any questions.

Generated by :no_entry_sign: dangerJS

mvandervelden commented 2 years ago

Thanks @Kaspik @ashfurrow ! Yes, a release would be awesome 😄

ashfurrow commented 2 years ago

Ugh, I'm running into Ruby issues locally. I'll get this released soon 👍

ashfurrow commented 2 years ago

Okay, this is released as version 0.30.0. Thanks again!