search

ashfurrow / danger-ruby-swiftlint

A Danger plugin for SwiftLint.
https://rubygems.org/gems/danger-swiftlint
MIT License
203 stars 80 forks source link

It got an error after upgrading `danger-swiftlint` to 0.30.0 #178

Closed daidongon closed 2 years ago

daidongon commented 2 years ago 
+ bundle exec danger
bundler: failed to load command: danger (/Users/vagrant/git/vendor/bundle/ruby/2.6.0/bin/danger)
Danger::DSLError: 
[!] Invalid `Dangerfile` file: swiftlint is not installed
 #  from Dangerfile:2
 #  -------------------------------------------
 #  swiftlint.config_file = '.swiftlint.yml'
 >  swiftlint.lint_files inline_mode: true
 #  
 #  -------------------------------------------
  /Users/vagrant/git/vendor/bundle/ruby/2.6.0/gems/danger-swiftlint-0.30.0/lib/danger_plugin.rb:68:in `lint_files'
  Dangerfile:2:in `eval_file'
  /Users/vagrant/git/vendor/bundle/ruby/2.6.0/gems/danger-8.4.2/lib/danger/danger_core/dangerfile.rb:311:in `eval'
  /Users/vagrant/git/vendor/bundle/ruby/2.6.0/gems/danger-8.4.2/lib/danger/danger_core/dangerfile.rb:311:in `eval_file'
  /Users/vagrant/git/vendor/bundle/ruby/2.6.0/gems/danger-8.4.2/lib/danger/danger_core/dangerfile.rb:204:in `block in parse'
  /Users/vagrant/git/vendor/bundle/ruby/2.6.0/gems/danger-8.4.2/lib/danger/danger_core/dangerfile.rb:201:in `instance_eval'
  /Users/vagrant/git/vendor/bundle/ruby/2.6.0/gems/danger-8.4.2/lib/danger/danger_core/dangerfile.rb:201:in `parse'
  /Users/vagrant/git/vendor/bundle/ruby/2.6.0/gems/danger-8.4.2/lib/danger/danger_core/dangerfile.rb:287:in `run'
  /Users/vagrant/git/vendor/bundle/ruby/2.6.0/gems/danger-8.4.2/lib/danger/danger_core/executor.rb:29:in `run'
  /Users/vagrant/git/vendor/bundle/ruby/2.6.0/gems/danger-8.4.2/lib/danger/commands/runner.rb:73:in `run'
  /Users/vagrant/git/vendor/bundle/ruby/2.6.0/gems/claide-1.1.0/lib/claide/command.rb:334:in `run'
  /Users/vagrant/git/vendor/bundle/ruby/2.6.0/gems/danger-8.4.2/bin/danger:5:in `<top (required)>'
  /Users/vagrant/git/vendor/bundle/ruby/2.6.0/bin/danger:23:in `load'
  /Users/vagrant/git/vendor/bundle/ruby/2.6.0/bin/danger:23:in `<top (required)>'
[!] The exception involves the following plugins:
 -  danger-swiftlint
aakarsh-sasi commented 2 years ago

Same issue

kokluch commented 2 years ago

I have this issue as well.

mvandervelden commented 2 years ago

As far as I can tell, #179 fixes the issue. Feel free to test that it does.

aakarsh-sasi commented 2 years ago

@mvandervelden needs merge right first?

mvandervelden commented 2 years ago

@aakarsh-sasi You could already use it by referring to the specific repo+branch or commit hash in your Gemfile.

ashfurrow commented 2 years ago

This should also be fixed in version 0.30.1. (Thanks @mvandervelden!) @daidongon can you confirm please?

daidongon commented 2 years ago

@mvandervelden @ashfurrow Thank you. It worked fine.