search

ashfurrow / danger-ruby-swiftlint

A Danger plugin for SwiftLint.
https://rubygems.org/gems/danger-swiftlint
MIT License
203 stars 81 forks source link

Option to run swiftlint with strict/lenient mode #57

Closed Sega-Zero closed 7 years ago

Sega-Zero commented 7 years ago

Would like to have an opportunity to run swiftlint in strict or lenient mode. Is there a way to pass an additional commandline parameters?

ashfurrow commented 7 years ago

Hmm, tricky. I've looked at the source code for parsing options and you might be able to pass additional arguments by adding as an option like "lenient" => "" but we don't expose a way to add arbitrary options to the command invocation. I think we should just add the ability for you to add arbitrary command-line options to swiftlint. Would you be interested in adding that feature?

Sega-Zero commented 7 years ago

I have no experience in ruby yet :)

ashfurrow commented 7 years ago

No worries! If you're keen, try it out, but no pressure. I'll try to get to it sometime this weekend.

ashfurrow commented 7 years ago

Okay, this should be good to go. I released the new feature as 0.10.0.