Closed Austinate closed 6 years ago
Thanks for review and nice words, @ashfurrow π Should we publish a new version with this changes? Any advice on this would be nice π
Yeah, good idea. I bumped the version and pushed to RubyGems. Thanks again for looking into this β I've been swamped and really appreciate it.
This PR addresses issues with folder paths containing whitespaces (in our case it is similar to "Project Name" and containing folder with source files has same "Project name" too).
First of all it removes changes made by #63 (sorry). Reason: It was wrong to escape Dir.pwd on that level since when it was used here it was causing and error because
Dir.chdir
for some reason fails if path is escaped Solution: escape dir_selected only infind_swift_files
where it is compared with escaped files pathsFixes escaping in
find_swift_files
function. Reason: When relative file path was first escaped and only after expanded it was producing such results in our case:which resulted in unusable file path/
Solution: First expand, then escape. Also escape used dir_selected in this function because in other case this code will return no files every time: