search

ashfurrow / danger-ruby-swiftlint

A Danger plugin for SwiftLint.
https://rubygems.org/gems/danger-swiftlint
MIT License
203 stars 81 forks source link

[Feature Request] Fail on warnings #78

Open erikkerber opened 6 years ago

erikkerber commented 6 years ago

There's a nice switch for failing the build on a linter error. We would love to fail on any warnings in the PR only. Setting warning_threshold: 0 in swiftlint itself limits is a bit too draconian for running CI test and development.

In other words, how bout a fail_on_warning: true ¯\_(ツ)_/¯

Checking for interest. I can make a PR if it sounds like a good idea.

ashfurrow commented 6 years ago

Hey! Neat idea – I'm definitely open to it, but I don't understand quite what it would do. Could you explain how the existing workflow would be different from this one? Maybe a PR makes the best sense to discuss the idea – let me know!

erikkerber commented 5 years ago

I derp'd the followup on this, apologies!

I'd close this, but it looks like @d-a-n almost(?) fixed this.

pluddy commented 5 years ago

This is one we are looking for in our project. Once we got to 0️⃣⚠️, we want to keep it that way! With Danger setup to block a PR, it would be nice if it could block code that introduces warnings, not just errors.

ashfurrow commented 5 years ago

Sure, if #109 doesn't do what you need, want to send a PR and we can review+merge?