Fix to use Included if specified in config

ashfurrow / danger-ruby-swiftlint

A Danger plugin for SwiftLint.

https://rubygems.org/gems/danger-swiftlint

MIT License

203 stars 81 forks source link

Fix to use Included if specified in config #79

Closed pmwiseman closed 6 years ago

pmwiseman commented 6 years ago

This PR addresses the fact that the included rule in the configuration isn't being utilized. Currently only the excluded rule is used. This causes a YAML file used in SwiftLint (that makes use of included) to not fully work as expected when using this plugin.

Problem: Files are only excluded from linting, they cannot be explicitly included.

Solution: In find_swift_files include files specified in included, after files have been excluded.

pmwiseman commented 6 years ago

No problem, it should be all set now. Thanks for your review! 😄

ashfurrow commented 6 years ago

Okay, this is in! Released as 0.12.0. Thanks again!