ashfurrow / danger-ruby-swiftlint

A Danger plugin for SwiftLint.
https://rubygems.org/gems/danger-swiftlint
MIT License
203 stars 81 forks source link

Danger crashes after plugin update #82

Closed delebedev closed 6 years ago

delebedev commented 6 years ago
-danger-swiftlint (0.10.1)
+danger-swiftlint (0.12.0)

CI run has failed with the following message:

[!] Invalid Dangerfile file: undefined method positive? for 0:Fixnum

 #  from /tmp/sandbox/workspace/Dangerfile:51
 #  -------------------------------------------
 #  swiftlint.config_file = '.swiftlint.yml'
 >  swiftlint.lint_files inline_mode: true
 #  
 #  -------------------------------------------

CI uses ruby-2.3.1

ashfurrow commented 6 years ago

Yikes, sorry about that! That is very strange. I installed ruby-2.3.1 with RVM and with a fresh irb shell, it appeared to work:

2.3.1 :001 > 0.positive?
 => false

I'm not sure what this could be – I'll take a look tomorrow. Anyone else have ideas?

ashfurrow commented 6 years ago

Okay, this was fixed by @thii and released as 0.12.1. Please let us know how it goes 👍

delebedev commented 6 years ago

Worked like a charm, thanks ! 🎆