search

ashfurrow / danger-ruby-swiftlint

A Danger plugin for SwiftLint.
https://rubygems.org/gems/danger-swiftlint
MIT License
203 stars 81 forks source link

danger-swiftlint lints files from merge commits, and not just my changes #86

Open 72A12F4E opened 6 years ago

72A12F4E commented 6 years ago

I noticed that when I have a merge commit in my history, danger-swiftlint will output lint violations that occur in the merges, and not my changes. This causes confusion.

ashfurrow commented 6 years ago

Sure, so I want to make sure I understand the issue. A PR's commit history would like like:

abcdef My first commit
deadee Merge commit from master
cafeba My second commit

And this plugin is listing the files changed in that middle commit? That's going to be tricky since we get the list of changed files from Danger, who in turn gets the data from loading git for the repo directory and calculating the diff based on PR target and base branches. Maybe it's possible to filter out merge commits from this diff, and then use the files from there?

I don't have a tonne of time to work on this, so if anyone else is available, help would be welcome :bow: