search

ashfurrow / danger-ruby-swiftlint

A Danger plugin for SwiftLint.
https://rubygems.org/gems/danger-swiftlint
MIT License
203 stars 81 forks source link

Fail on error doesn't work as expected. #89

Closed omirho closed 6 years ago

omirho commented 6 years ago

fail_on_error behavior should be to fail Danger, but instead it crashes danger with a cryptic message.

screen shot 2018-02-21 at 9 15 50 pm

This is due to using raise instead of Danger's fail method.

I came upon this issue when I removed inline_mode from my config.

After checking the history, I came upon this PR which introduced the issue.

I'll be happy to raise a PR to fix this after receiving a 👍

omirho commented 6 years ago

Also, inline_mode fails Danger on errors irrespective of fail_on_error being true or not. This should either be mentioned in the README or changed. I think it should be changed though.

ashfurrow commented 6 years ago

Hmm! Great catch, thanks. A PR to fix this would be welcome 🙇 As for the inline_mode, I admit I've never used it. It sounds like a bug, would you care to open an issue with steps to reproduce? Thanks again!