Closed ashfurrow closed 6 years ago
We currently use strings (either 'warn' or 'fail') when invoking send, here:
'warn'
'fail'
send
https://github.com/ashfurrow/danger-ruby-swiftlint/blob/3619427939d53b51898f34dffb229889b7c0bd90/lib/danger_plugin.rb#L218
Ruby prefers to use symbols instead of strings, and indeed send will accept either. See section 1.3.2 of these docs. This PR just uses symbols instead of strings. It also corrects a few Rubocop violations.
LGTM! :)
We currently use strings (either
'warn'
or'fail'
) when invokingsend
, here:https://github.com/ashfurrow/danger-ruby-swiftlint/blob/3619427939d53b51898f34dffb229889b7c0bd90/lib/danger_plugin.rb#L218
Ruby prefers to use symbols instead of strings, and indeed
send
will accept either. See section 1.3.2 of these docs. This PR just uses symbols instead of strings. It also corrects a few Rubocop violations.