search

ashfurrow / danger-ruby-swiftlint

A Danger plugin for SwiftLint.
https://rubygems.org/gems/danger-swiftlint
MIT License
203 stars 81 forks source link

Add support for environment variables in Swiftlint configs #99

Closed AvdLee closed 6 years ago

AvdLee commented 6 years ago

Swiftlint configs support environment variables since 0.21.0 (See https://github.com/realm/SwiftLint/issues/1512).

As we were filtering out excluded and included paths if they didn't exist on disk, environment variables would not reach Swiftlint and would not get parsed. With this PR we're implementing support for environment variables just like Swiftlint.

An example usage can be found here, where we use it with WeTransfer to reuse config files across repositories: https://github.com/WeTransfer/WeTransfer-iOS-CI/blob/master/SwiftLint/.swiftlint-source.yml#L50

AvdLee commented 6 years ago

@ashfurrow it would be great if we could do a release as well with these changes so we can use this release internally at WeTransfer :)

AvdLee commented 6 years ago

@ashfurrow it should all be good now. I've sent you a private message on twitter with my email.