search

ashhitch / gatsby-plugin-wpgraphql-seo

Gatsby Plugin to Bring Yoast Seo Data into Gatsby via WpGraphQL.
MIT License
13 stars 8 forks source link

Seems to require gatsby-plugin-react-helmet without stating so #26

Closed joshdavenport closed 1 year ago

joshdavenport commented 2 years ago

Am I correct in that gatsby-plugin-react-helmet is required in order for this plugin to work? Wasn't getting any output in my static output and was going crazy until I added it. Totally makes sense that it's required in order for react-helmet to work and is obvious in hindsight but not having used helmet before, letalone in a Gatsby context so it just didn't occur to me.

If this is the case I think it should be stated in the docs - happy to PR if I'm right on this

miraclemaker commented 2 years ago

Very helpful, thanks. I found that without gatsby-plugin-react-helmet the tags were visible in a normal browser, but they weren't visible in the SSR'd pages and so weren't appearing in the likes of the Facebook debugger.

ashhitch commented 2 years ago

Hi yes it is a requirement before the new head API it was installed my default, so prob worth a note now. Happy to take a PR

joshdavenport commented 2 years ago

Cool, makes sense. PRing now