search

ashi009 / node-fast-crc32c

node.js CRC-32C algorithm with hardware acceleration and software fallback.
MIT License
29 stars 20 forks source link

Latest version fails testing #9

Closed gr0uch closed 5 years ago

gr0uch commented 8 years ago

Hi,

Upgrading from 1.0.2 to 1.0.3 caused tests to fail. I looked at the commits and it seems Node 4 support was dropped in a patch version (!)

It seems to fail without having a fallback option.

Error: Failed to find available CRC-32C implementation.
    at /home/travis/build/fortunejs/fortune/node_modules/fast-crc32c/loader.js:20:7
    at Object.<anonymous> (/home/travis/build/fortunejs/fortune/node_modules/fast-crc32c/loader.js:22:3)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/home/travis/build/fortunejs/fortune/lib/net/http_server.js:4:13)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/home/travis/build/fortunejs/fortune/lib/index.js:15:12)
ashi009 commented 8 years ago

I thought nam will automatically resolve to the latest supported version. Sorry for that, let me fix it.

ashi009 commented 8 years ago

Rolling out v1.0.4 to revert the change. Please update to the latest version.

ashi009 commented 5 years ago

17 has addressed this.