search

ashiguruma / patternomaly

Easily generate patterns for use in data graphics
MIT License
524 stars 37 forks source link

add Compatibility with IE11 #14

Closed castorls closed 5 years ago

castorls commented 6 years ago

The Object.assign function doesn't exist in IE11. I've added the MDN polyfill if the function is not recognized.

This version of your lib is well working in our product on IE11.

ashiguruma commented 6 years ago

Hi @castorls. As the project uses Babel I've added the Object.assign polyfill to the .babelrc file.

Can you check out the branch object-assign-ie11 (referenced above), build it and let me know if that fixes the issue for you? I'll try and get it tested in IE11 as well.

mcelotti commented 6 years ago

Hi @ashiguruma I've tested the object-assign-ie11 branch on IE11 and I get " Expected ')' " in console, but I did not investigate further.

m4m4m4 commented 5 years ago

What is the status on this, is this project active?

mcelotti commented 5 years ago

Hi @m4m4m4 I don't think this is going to be fixed, I personally switched to png backgrounds since they work on IE11 https://www.chartjs.org/docs/latest/general/colors.html

m4m4m4 commented 5 years ago

I just built the object-assign-ie11 branch. IE11 works great if you use the built files in the \dist folder

jackmakesthings commented 5 years ago

Seems like that branch works; can it (or this) please be merged in? Trying to use this on a project now and the lack of IE11 support is an issue.

m4m4m4 commented 5 years ago

Can we get a new release in npm with this fix?

ashiguruma commented 5 years ago

@m4m4m4 On it but am having some build troubles but should have a tag out soon.