ashik94vc / ElegantNumberButton

Widget which acts as a number counter which changes its number on +/- press.
Apache License 2.0
180 stars 62 forks source link

Add MainActivityTest and some changes and refactoring #29

Closed alejandrocq closed 4 years ago

alejandrocq commented 4 years ago

Issue #28

I have made this improvements:

I have commited my .idea files too, but I think that you should remove that directory from git (usually is not a good idea to track IDE files, and also gradle files have almost all the information to get the developing environment ready).

I hope this is useful :).

ashik94vc commented 4 years ago

Hey, thanks a lot. Would you be able to add the idea files to gitignore too. I'll review your code tomorrow around morning and will merge it.

alejandrocq commented 4 years ago

Hey, thanks a lot. Would you be able to add the idea files to gitignore too. I'll review your code tomorrow around morning and will merge it.

You're welcome! :) Yes, I can do that this afternoon. I can do another PR if you prefer to merge this before.

alejandrocq commented 4 years ago

I have added two commits before the changes to remove .idea folder files from git, and also I have simplified the .gitignore file a bit ;).