search

ashiklom / hector-rcmip

Reduced Complexity Model Intercomparison using the Hector model (jgcri.github.io/hector)
Other
1 stars 2 forks source link

Currently setting alpha as volcanic rather than aerosol scaling #9

Closed bvegawe closed 4 years ago

bvegawe commented 4 years ago

In R/run_with_param.R, alpha is set as the volcano forcing scalar rather than the aerosol scaling. In the calibration output in data-raw/brick-posteriors/emissions_17k_posteriorSamples.csv, alpha is the aerosol scaling.

The issue affects these lines in R/run_with_param.R: lines 51-52 hector::VOLCANIC_SCALE(), palpha, hector::getunits(hector::VOLCANIC_SCALE()) and line 65 param_volscl = palpha,

Also line 48 in scripts/01-run-simulations.R params <- unique(dat[, .(isamp, param_ecs, param_diffusivity, param_volscl)])

Edit: added a pull request but feel free to do it another way.

bvegawe commented 4 years ago

Addressed with the merging of #10 . Hopefully that doesn't have any unforeseen effects.