search

ashima / webgl-noise

Procedural Noise Shader Routines compatible with WebGL
MIT License
2.8k stars 302 forks source link

mod289 defined only for vec3 #3

Closed marcpetit closed 13 years ago

marcpetit commented 13 years ago

Hi !

While using the 3D classical noise, I got one complaint, about mod289 using vec4 while Pi0 and Pi1 are vec3. As permute actualy uses a vec3, I just added a vec3 version of mod289, and everything worked fine.

Thanks for sharing those useful functions.

Marc

stegu commented 13 years ago

Thanks for pointing that out. Fixed it. Don't know why I never caught that myself.

marcpetit commented 13 years ago

You're welcome.

As I'm prototyping for evolutions of an old system, I'm using #version 100. It might be less permissive than 120 ? Or maybe my driver (NVidia 258.49) has something to do with it ?

2011/10/11 Stefan Gustavson < reply@reply.github.com>

Thanks for pointing that out. Fixed it. Don't know why I never caught that myself.

Reply to this email directly or view it on GitHub: https://github.com/ashima/webgl-noise/issues/3#issuecomment-2361350