search

ashinkarov / i3-extras

Repository to keep patches and extras for i3 window manager.
662 stars 34 forks source link

i3bar-xbm-icons.patch dose not worke with i3-4.8 #9

Closed Titzi90 closed 10 years ago

Titzi90 commented 10 years ago

The version of the patch does not work with the new i3 version

ashinkarov commented 10 years ago

Thanks for spotting that! I am pretty busy these days, so I don't promise to fix it very quickly. But I will have a look.

ashinkarov commented 10 years ago

Right I have managed to try out version 4.8. the patch seem to work fine. Can you provide some more details how exactly does it fail?

AladW commented 10 years ago

Here's an alternate version of the xbm patch:

https://gist.githubusercontent.com/sudaraka/507a782a9c9d489485a2/raw/a5468c63759c1d3c340e6e51e5b1a8f0d8430e37/i3bar-4.8-icons.patch

Titzi90 commented 10 years ago

Hi, thank you AladW your patch works perfectly.

ashinkarov commented 10 years ago

Ahhh! I finally got it. You are saying that the patch as it was didn't apply simply with git apply. I have rebased the patch onto the next branch, so it does work now. Sorry for the confusion.

Titzi90 commented 9 years ago

Hi, sorry if it was not clear what I wanted to say.

can you rebase it again to the new version (4.10.2). Thank you.

ashinkarov commented 9 years ago

The commit @93a888c92a6c0de5c70c742e9a0fa03f9650affb fixes it.