Open jmazon opened 4 years ago
Hi, thanks for your comments, and sorry that it took me so long to come back to you. In all fairness I didn't try the pidgin setup since ~2012. However, I still use the weechat version of the plugin every day (probably should update the docs to reflect that). Now, as for the problem you mention, I immediately see that if there were a library that reexports the same symbols as the plugin, bad things could happen, e.g. the crash that you experience. It seems like an easy fix, as all the trie uses are local, so we can either rename the interface functions, or inline them, or whatever. However, before fixing this, I have tried to reproduced the behaviour and failed to do so.
I am using Pidgin 2.14.1 (libpurple 2.14.1)
, glib 2.64.3
, gtk+ 2.24.32-r1
. The updated Makefile builds the plugin (with a few warnings) and the plugin works fine from pidgin --- I can register the user with \detrans
, and all the traffic from that user is being detransliterated.
Can you still reproduce the crash? What exactly do you do differently?
Hi,
The harfbuzz issue doesn't reproduce. The weechat one still does; here's the log for reference:
$ LC_ALL=C make Package weechat was not found in the pkg-config search path. Perhaps you should add the directory containing `weechat.pc' to the PKG_CONFIG_PATH environment variable Package 'weechat', required by 'virtual:world', not found cc -Wall -Wextra -std=gnu99 -march=native -mtune=native -fPIC -D_DEFAULT_SOURCE -D_GNU_SOURCE -D_BSD_SOURCE \ -c -o weechat-detrans.o weechat-detrans.c weechat-detrans.c:18:10: fatal error: weechat-plugin.h: No such file or directory 18 | #include
| ^ ~~~~~ compilation terminated. make: *** [Makefile:51: weechat-detrans.o] Error 1
The crash still occurs. (procedure: tick the plugin's checkbox in Pidgin's plugin list)
I don't have a debug-enabled version of pidgin anymore, but I can at least trace the dependencies. Left is package name; right is SONAME dependency. I'm using the stock ArchLinux packages.
Hope this helps!
Hi,
I won't be using your plugin (it doesn't do what I need), but before I deleted my work folder I thought I'd let you know about how the compilation process went.
all
target (I don't have/use it, and the build process fails when it tries to build the plugin for it)trie_new
. In my case, this resulted in an automatic, systematic and instant Pidgin crash when enabling the plugin. This one took a much longer time to debug. The fix in my case was to add a-fvisibility=hidden
flag totrie.o
's compilation line. (a cleaner one would likely be to only export the bare minimum of symbols needed by Pidgin)In any case, thanks for opensourcing!