ashinzekene / angular-rave

💵 An angular2+ module for integrating payments using the rave gateway
https://ashinzekene.github.io/angular-rave
MIT License
22 stars 14 forks source link

Observations #31

Open funsholaniyi opened 4 years ago

funsholaniyi commented 4 years ago

I noticed the callback event is not as effective in catching failing payments as the docs describe, and a scenario you might want to consider is Mobile money payment, e.g. MPesa and MTN Ghana MoMo, as flutterwave returns a pending payment payload, and does not mean a payment failure since the user still has to go input their PIN on their phone, thus eventually letting the web hook tell you it's final status

A suggestion will be to have an explicit callback function for each payment status and currently, the onclose event behaves as a better replacement for specifying the callback event.

I will suggest onclose should listen to the modal close event, as it is the default confirm box is in place for now

Overall, great work.

ashinzekene commented 4 years ago

Hello Funsho, thanks for the feedback. I don't get most of what you said you said

A suggestion will be to have an explicit callback function for each payment status

I will suggest onclose should listen to the modal close event, as it is the default confirm box is in place for now