search

ashinzekene / angular4-paystack

💵 An angular2+ module for paystack transactions
https://ashinzekene.github.io/angular4-paystack/
MIT License
59 stars 37 forks source link

changed (close) events to (onClose). #27

Closed hellotunmbi closed 3 years ago

hellotunmbi commented 4 years ago

The close event name is 'onClose' but the code documentation says 'close'. (close) obviously didn't work but (onClose) did.

I fixed this typo in the README.md and included examples.

ashinzekene commented 4 years ago

Thanks a lot for this. Sorry I was unable to review since

Please can you help check that the changes are only for the onClose you worked on?

hellotunmbi commented 4 years ago

Yes, I only worked on the onClose event and updated it in the Readme file

ashinzekene commented 4 years ago

Hello @hellotunmbi checking the diff it shows there are a lot of other changes other than the one intended. Please make a correction to this

ashinzekene commented 3 years ago

Sorry had to close this