search

ashish-chopra / angular-gauge

A reusable gauge directive for Angular 1.x apps and dashboards
https://ashish-chopra.github.io/angular-gauge/
MIT License
95 stars 36 forks source link

Removed the forced font type #17

Closed rohan-buechner closed 7 years ago

rohan-buechner commented 7 years ago

Not needed as it overwrites the CSS font

ashish-chopra commented 7 years ago

Hey @rohan-buchner thanks for your pull request. But, why you wanted to remove font-type that we used as standard for the gauge?

rohan-buechner commented 7 years ago

@ashish-chopra. My system / app does not have that font, that was supplied. I also didn't see that the component supplied it. Therefor it defaulted to something quite ugly (like times new roman)... I think it would be best to either:

ashish-chopra commented 7 years ago

hey @rohan-buchner, really sorry for responding late. You are exactly right, and this is what i had also thought when i was writing this library and faced a similar issue on different machine during testing, but somehow missed to address it. I had planned to introduce a property font-family which takes the strings like "Arial Helvetica" to setup the font for gauge's text displays.

Also for quick user who do not bother to change the font, i would suggest to add a fallback font, instead of removing font-family altogether. i.e. font-family: 'Open Sans' Arial. Let 'Open Sans' be the primary font (since its such a sleek and sexy font) and 'Arial' be secondary (fallback). And if user wants to override, then he can use 'font-family' attribute as mentioned above.

Any suggestions? And can you amend the pull request to add the fallback font?. I will merge it then. Thanks a lot.

ashish-chopra commented 7 years ago

I have reached to the similar conclusion that you pointed out first. I think removing font family altogether and using default fonts that are naturally inherited through styling based on the application is a good decision. Hence, i take this pull request. Thanks a lot :+1:

rohan-buechner commented 7 years ago

@ashish-chopra thank you! I'll revert my project to the source branch again ;)