ashish-gehani / SPADE

SPADE: Support for Provenance Auditing in Distributed Environments
GNU General Public License v3.0
166 stars 72 forks source link

PROV-O seems to be malformed #9

Closed ruimaranhao closed 8 years ago

ruimaranhao commented 8 years ago

SPADE produces invalid ttl files. For example, there are lots of close braces that have no matching open brace:

data:f25181be9786b40c9d3a880b3b9223816a5bd9eefc9861dafea8458710efb883 prov      data:type "WasTriggeredBy";
]; .

I've not tested PROV-N, but it might have the same issue.

hassaanirshad commented 8 years ago

SPADE works with OPM by default and to convert that to PROV model, OPM2Prov filter needs to be applied. Once the filter is added you should be able to generate correct ttl and provn files. Please add the mentioned filter before running any reporter using the following command: 'add filter OPM2Prov 0' where 0 is the index of the filter.

Please let us know when you are able to correctly generate Prov storage output.

ruimaranhao commented 8 years ago

Still, the '];' seems to be out of place. There is no '['. Could you please double check that the pretty-printer is working ok.

Thanks.

ruimaranhao commented 8 years ago

It did generate PROV-O. I think the pull request still might make sense, though.

hassaanirshad commented 8 years ago

The following two links should help you regarding the use of filters in SPADE:

https://github.com/ashish-gehani/SPADE/wiki/Available%20filters https://github.com/ashish-gehani/SPADE/wiki/Using%20filters

Please let us know in case of any more queries.

Regards, Hassaan

On Tue, Oct 6, 2015 at 3:51 AM, Rui Maranhao notifications@github.com wrote:

Is there any documentation on how to use the OPM2Prov filter?

Thanks.

— Reply to this email directly or view it on GitHub https://github.com/ashish-gehani/SPADE/issues/9#issuecomment-145820237.

hassaanirshad commented 8 years ago

Good to know that it worked using that filter. About the code that you pointed to, the addition of the opening square brackets won't produce correct PROV-O if OPM2Prov filter isn't used. The Prov storage is simply not supposed to work with OPM.

Adding a note on wiki about using OPM2Prov filter and closing the issue.

Thanks.