Unexpected Behavior with "Dataform: Run file(s) / tag(s) with options" Command

ashish10alex / vscode-dataform-tools

Dataform tools - a vscode extension

https://marketplace.visualstudio.com/items?itemName=ashishalex.dataform-lsp-vscode

MIT License

20 stars 4 forks source link

Unexpected Behavior with "Dataform: Run file(s) / tag(s) with options" Command #27

Closed j0nandr1 closed 2 months ago

j0nandr1 commented 2 months ago

Hi, I'm experiencing an issue with the "Dataform: Run file(s) / tag(s) with options" command. When I try to execute

run a tag
run type -> default
full refresh -> yes

But it only adds these parameters --tags=update_test_tables --include-deps to the Dataform run command. As a result, it try to run all dependencies and no full refresh. But I would expect, that it runs no dependents or dependencies and a full refresh.

Can this be fixed, or am I messing up somewhere?

ashish10alex commented 2 months ago

Hi @j0nandr1 , Thanks for raising the issue. Please upgrade to the latest version v0.0.60 where this issue should be fixed. Please let me know if this works for you :)

j0nandr1 commented 2 months ago

Hi @ashish10alex, thanks for the quick reply. Now it added the --full-refresh and removed the --include-deps parameter. But the --tags= is missing.

ashish10alex commented 2 months ago

Hi @j0nandr1 ,
Apologies, just shipped a fix now. Please try v0.0.61 and let me know if it works as expected ?

Also, I was interested in how did you know about the extension / this feature as I had just shipped the feature. Was interested in how you came about using the extension. Additionally, please feel free to create an issue for any feature request you might have .

j0nandr1 commented 2 months ago

No problem, thanks for the fast fix! Now, it works as expected.

A work colleague showed me the extension and was the one who requested this feature.