search

ashish10alex / vscode-dataform-tools

Dataform tools - a vscode extension
https://marketplace.visualstudio.com/items?itemName=ashishalex.dataform-lsp-vscode
MIT License
20 stars 4 forks source link

Bug: Dataform workspace setup issue with workflow_settings.yaml file #35

Closed laurentvandelle closed 1 month ago

laurentvandelle commented 1 month ago

Description

When the extension is setting up it ask me to do a install dataform even if I have workflow_settings.yaml file and the query / compiler don't work since the setup is not successful

Steps to Reproduce (for bugs)

  1. Create a dataform project with a workflow_settings.yaml file
  2. Launch vscode
  3. You have a warning message Not a Dataform workspace. Workspace: ${workspaceFolder} does not have workflow_settings.yaml or dataform.json or node_modules at its root and an error message Dataform workspace not setup
  4. Go to a sqlx file
  5. Query / compiler don't work

Expected Behavior

The project is setup correctly and query / compiler work

Actual Behavior

The project is not setup correctly and query / compiler don't work

Screenshots or Code

image

Environment

Release 0.2.11

https://github.com/ashish10alex/vscode-dataform-tools/commit/5cb0fd3401100040e545df0f2e4d25bcc5b60dbb#diff-39b2554fd18da165b59a6351b1aafff3714e2a80c1435f2de9706355b4d32351R273

laurentvandelle commented 1 month ago

I've downgraded to 0.2.10 for now then no rush I can test some stuff if you need

ashish10alex commented 1 month ago

thanks @laurentvandelle for creating the detailed issue. looks like I have to tweak / roll back the code change the way I have implemented the feature does not cater to both Dataform v3 and v2 users. The idea was to make it easy for new users to use the plugin.

--

If you have any additional feature requests / feedback please let me know too.

ashish10alex commented 1 month ago

@laurentvandelle , I have published a new version v0.2.12 which reverts the commit that introduced the bug. Please let me know if it works as before. Meanwhile please feel free to pop in with any ideas / feedback

TheSmartMonkey commented 1 month ago

I am the same guy btw At work I can't for some reason update to the last version. I am on mac os I tried on my personal computer that is on windows and I can update to the latest version. With the same repo config with workflow_settings.yaml file it works on v0.2.12 on my personal computer

ashish10alex commented 1 month ago

Hi, so it works on windows but not on mac ? btw the latest version now is v0.2.13. I use a mac btw and it works with dataform v3. Please let me know if it does not work on windows and what error you get

TheSmartMonkey commented 1 month ago

I've been able to update on my mac to v0.2.13 all work fine thanks ! 👍