search

ashish2199 / Aidos

A beginner friendly project with aim of creating our own version of Bomberman.
GNU General Public License v3.0
41 stars 27 forks source link

Collission Detection improvements #42

Open ItsStolas opened 6 years ago

ItsStolas commented 6 years ago

I added walls to the game.

This exposed a problem with our current collision system, though.

First I had to alter the functions slightly to return boundaries correctly, this was a minor change. The major change, we will have to discuss.

For collision detection, you want to test where the player IS GOING TO BE, not where he currently is. That's my understanding anyway. The way we have it currently, this is impossible without some ugly hacky code.

Does anyone have any ideas about how to implement this nicely?

ashish2199 commented 6 years ago

@CoreyHendrey which hack are you talking about ?

Also have a look at the dying animation pull request, I added.

StewartWallace1115 commented 6 years ago

I submitted a PR. It is an OK solution until we find a better one.