ashkan18 / graphlient

Ruby GraphQL Client
MIT License
251 stars 44 forks source link

Added tests against Github V4 API. #48

Closed dblock closed 6 years ago

dblock commented 6 years ago

These tests pass, so my problem in https://github.com/ashkan18/graphlient/issues/47 is probably something else.

dangerpr-bot commented 6 years ago
1 Warning
:warning: Unless you’re refactoring existing code, please update CHANGELOG.md.

Here's an example of a CHANGELOG.md entry:

* [#48](https://github.com/ashkan18/graphlient/pull/48): Added tests against github v4 api - [@dblock](https://github.com/dblock).

Generated by :no_entry_sign: Danger

dblock commented 6 years ago

Interestingly graphql-ruby doesn't seem to play nice when https://github.com/davetron5000/gli is included via include GLI::App, debugging.

@ashkan18 You might want to merge these tests, they are good story.

ashkan18 commented 6 years ago

🙌 thanks for adding specs!