Fix typo preventing access to response object on error

ashkan18 / graphlient

Ruby GraphQL Client

MIT License

251 stars 44 forks source link

Fix typo preventing access to response object on error #62

Closed jmondo closed 5 years ago

jmondo commented 5 years ago

The same tests are failing on master branch

ashkan18 commented 5 years ago

thanks @jmondo for 👀 , I fixed the issue on master the issue was, on newer ruby versions Travis was using a newer 1.9.7 version of graphql which we use for tests. Ended up fixing it by setting graphql version for tests in Gemfile. When had a chance, rebase with master and we can merge.

jmondo commented 5 years ago

@ashkan18 looks like we're green!

ashkan18 commented 5 years ago

thanks @jmondo for your contribution 💜

ashkan18 commented 5 years ago

just cut 0.3.6 with this change 🙌

jmondo commented 5 years ago

Whoa nice thanks for cutting the release so quickly :) I can remove my monkey patch! Haha

On Tue, Jul 23, 2019 at 05:02 Ashkan Nasseri notifications@github.com wrote:

just cut 0.3.6 with this change 🙌

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ashkan18/graphlient/pull/62?email_source=notifications&email_token=AAETKJ3MDM5XZ4AC5GNLPSDQA3XNRA5CNFSM4IF4Y2LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2S4KPI#issuecomment-514180413, or mute the thread https://github.com/notifications/unsubscribe-auth/AAETKJ4OCFMUQDFN4OTXPITQA3XNRANCNFSM4IF4Y2LA .

-- -- John