search

ashkan18 / graphlient

Ruby GraphQL Client
MIT License
251 stars 43 forks source link

Lock activesupport version to < 6 #67

Closed neroleung closed 4 years ago

neroleung commented 4 years ago

Since graphql-client gem requires activesupport, and the latest version of activesupport requires zeitwerk (~> 2.2) which requires ruby to be >= 2.4.4, locking activesupport version to < 6 so that Travis will pass.

yuki24 commented 4 years ago

Since graphql-client gem requires activesupport, and the latest version of activesupport requires zeitwerk (~> 2.2) which requires ruby to be >= 2.4.4, we need to update travis.yml to use at least ruby 2.4.4. This is for getting Travis to pass.

I would just pin activesupport to < 6 since graphql-client should be responsible for ensuring compatibility with underlying dependencies. Rails 6 only works on Ruby 2.5 or 2.6, and we definitely don't want to drop support for 2.4 and older versions. It's not something we can decide lightly.

I will also re-iterate that each commit should only include a meaningful chunk of work and I see three changes in one PR. It would be great if you could extract or at least make three different commits.

neroleung commented 4 years ago

@yuki24, it's done.

dblock commented 4 years ago

Also thanks for taking care of this.

dangerpr-bot commented 4 years ago
1 Warning
:warning: Unless you’re refactoring existing code, please update CHANGELOG.md.

Here's an example of a CHANGELOG.md entry:

* [#67](https://github.com/ashkan18/graphlient/pull/67): Lock activesupport version to < 6 - [@neroleung](https://github.com/neroleung).

Generated by :no_entry_sign: Danger

dblock commented 4 years ago

I merged. @yuki24 you also have collaborator privileges here I think, we trust you to hit merge too :)