BenDrozdoff
commented
4 years ago Possibly also relevant, we internally altered the constructor a bit due to the structure of Faraday::TimeoutError
module Graphlient
module Errors
class FaradayServerError < ServerError
# Overriding this constructor. Timeout errors do not have a `response` member, thus we get NoMethodError on [].
def initialize(inner_exception)
super(inner_exception.message, inner_exception)
@inner_exception = inner_exception
return unless inner_exception.response.present?
@response = inner_exception.response[:body]
@status_code = inner_exception.response[:status]
end
end
end
end
ashkan18
dblock
iMacTia
Starting in Faraday 0.17.1, the TimeoutError is no longer an instance of Faraday::ClientError, which is caught here as a Graphlient::Errors::FaradayServerError
See this line and this line as the breaking change.
We have some extra error handling logic based on Graphlient::Errors::FaradayServerErrors, so for now we've had to shoehorn in Timeout catching, whereas before they came through in Graphlient.
I haven't been able to dive in enough to figure out exactly what the right solution is, but I'm happy to be part of the discussion