search

ashkan18 / graphlient

Ruby GraphQL Client
MIT License
251 stars 43 forks source link

Add Truffleruby head to CI #80

Closed gogainda closed 3 years ago

ashkan18 commented 3 years ago

thanks @gogainda for adding this, will merge once the build is passed.

ashkan18 commented 3 years ago

@gogainda we should keep other ruby versions around. any reason you took them out?

gogainda commented 3 years ago

It was just for testing. Travis's become pretty slow recently, will revert those changes. Do you consider moving to Github Actions?

ashkan18 commented 3 years ago

It's strange that when you only have truffleruby it seems to be passing but with multiple versions it fails. right?

RE github actions, I haven't used them but im totally up to try it, is it easy to setup?

gogainda commented 3 years ago

yep, looks like some transient issue to me. will fill an issue in truffleruby repo. Regarding the upgrade to Github Actions , it's hard to say if it's hard or not, but in the end CI is faster and more stable for truffleruby builds

ashkan18 commented 3 years ago

Thanks! and thanks for Github Actions suggestion! I'll give it a try sometime soon, would be fun learning it.

gogainda commented 3 years ago

closing in favor https://github.com/ashkan18/graphlient/pull/83