search

ashkan18 / graphlient

Ruby GraphQL Client
MIT License
251 stars 44 forks source link

Allow use of big int in rails notation #86

Closed lax1n closed 2 years ago

lax1n commented 2 years ago

Currently not possible to use BigInt in rails notation.

yuki24 commented 2 years ago

I'm not quite following what this PR does. The GraphQL does not have the data type BigInt while the graphql-ruby gem does have one. There are also a few third-party bigint implementations in the npm world. What are the relations to them and how does this PR make graphlient better?

dblock commented 2 years ago

@lax1n Add a test that maybe demonstrates how this is a good idea for Graphlient?

lax1n commented 2 years ago

I'm not quite following what this PR does. The GraphQL does not have the data type BigInt while the graphql-ruby gem does have one. There are also a few third-party bigint implementations in the npm world. What are the relations to them and how does this PR make graphlient better?

You're completely right!

I can add that my motivation for adding support for BigInt in ruby notation was that I was working on an integration with TheGraph where this scalar type was required and ended up doing a monkey patch to make it work on my end.

That being said, I have not done enough research on the matter to make a case for this PR anymore so I'll close it for now.

Thanks for the feedback!