Closed rellampec closed 1 year ago
1 Warning | |
---|---|
:warning: | Unless you're refactoring existing code, please update CHANGELOG.md. |
Here's an example of a CHANGELOG.md entry:
* [#94](https://github.com/ashkan18/graphlient/pull/94): Enable fragments - [@rellampec](https://github.com/rellampec).
Generated by :no_entry_sign: Danger
Looks good. Let's increment the version to 0.7.0 per semver part of this PR and update/edit https://github.com/ashkan18/graphlient/blob/master/CHANGELOG.md please?
@ashkan18 added PR changelog and incremented to version 0.7.0
Looks like tests are failing, once they are green let's merge 🙌 thanks for doing this ❤️
@ashkan18 I had to change the connection message to pass the tests locally.
I have reverted that test to its previous expect
ed value.
Awesome! thanks for the quick fix ❤️
@dblock I have added some logic to resolve constants defined in a different context, provided that the full namespace path is included on
Graphlient::Query::#parse
, althoughstub_const
doesn't seem to offer a way to mock the scenario.In the example above, a graphlient.parse in
Baz
referring to___Bar__Fragment
would fail to resolve. And for this reason, I have addedevaluate
(capture the context) andresolve_fragment_constant
(constant resolution + type validation).Graphlient::Errors:Error
for the type validation, but you may see this requires its own error type. so I have not addedspec
toraise
.