ashkensington-zz / elmah

Automatically exported from code.google.com/p/elmah
Apache License 2.0
0 stars 0 forks source link

unhandled elmah exceptions crashing IIS #226

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
This is a followup to issue 72. I noticed in the mail module where a try/catch 
block was added to the mail module. I was wondering if there was a reason 
try/catch blocks were not added at all (or nearly all) entry points to prevent 
elmah from crashing IIS? Even the mailer only has a try/catch around a small 
patch of code, and not a catch-all handler.

We're wanting to add Elmah to our web app, but we can't allow it to crash IIS 
in our environment. I'm thinking of just adding try/catch blocks myself, so:

1. Are there reasons for not catching all unhandled exceptions in the elmah 
module(s)?

2. If I modify the elmah sources to do this, would you want me to send you a 
patch? Also, do you have an opinion on whether catch-all should be used, or 
should only specific exceptions be caught?

3. Any other thoughts/insights/suggestions you have into this issue is 
appreciated.

What is the expected output? What do you see instead?

IIS not crashing, but is.

Original issue reported on code.google.com by craigp...@gmail.com on 10 May 2011 at 7:18

GoogleCodeExporter commented 9 years ago
This issue has been migrated to:
https://github.com/elmah/Elmah/issues/226
The conversation continues there.
DO NOT post any further comments to the issue tracker on Google Code as it is 
shutting down.
You can also just subscribe to the issue on GitHub to receive notifications of 
any further development.

Original comment by azizatif on 25 Aug 2015 at 8:20