search

ashkulz / NppFTP

Plugin for Notepad++ allowing FTP, FTPS, FTPES and SFTP communications
https://ashkulz.github.io/NppFTP/
320 stars 93 forks source link

List Parameters not used with SFTP connections #214

Open rebpgh opened 6 years ago

rebpgh commented 6 years ago

Description of the Issue

I use NPPFTP to connect to our SFTP Linux servers (RedHat 7.3). In my Profile(s), under FTP Misc. I use a LIST Parameters value of -l (I don't want to see hidden files). This option has never worked.

Steps to Reproduce the Issue

  1. Setup profile to connect to SFTP server
  2. Put -l in the FTP Misc LIST Parameters
  3. Connect to server
  4. Navigate to folder that has hidden and non-hidden files and folders

Expected Behavior

The Folder/File tree list should not list any folder or file beginning with a "."

Actual Behavior

See images. Hidden files and folders always show.

Debug Information

authentication: password Notepad++ v7.5.4 (32-bit) Build time : Jan 1 2018 - 01:47:45 Path : C:\Program Files (x86)\Notepad++\notepad++.exe Admin mode : ON Local Conf mode : OFF OS : Windows 7 (64-bit) Plugins : ComparePlugin.dll DSpellCheck.dll mimeTools.dll NppConverter.dll NppExport.dll NppFTP.dll NppTextFX.dll PluginManager.dll PythonScript.dll XMLTools.dll

Looking at https://github.com/ashkulz/NppFTP/blob/v0.27.1/src/FTPProfile.cpp

under FTPClientWrapper* FTPProfile::CreateWrapper() {

I see the following: case Mode_FTP: case Mode_FTPS: case Mode_FTPES: { SSLwrapper->SetListParams(m_ftpListParams);

But for case Mode_SFTP: { There's no SetListParams call. Shouldn't there be???? Thanks!

image

image

image

chcg commented 1 year ago

For SFTP no parameters could be added to the list call as https://api.libssh.org/stable/group__libssh__sftp.html is used. See https://github.com/ashkulz/NppFTP/blob/master/src/FTPClientWrapperSSL.cpp#L119 vs. https://github.com/ashkulz/NppFTP/blob/master/src/FTPClientWrapperSSH.cpp#L110