search

ashkulz / NppFTP

Plugin for Notepad++ allowing FTP, FTPS, FTPES and SFTP communications
https://ashkulz.github.io/NppFTP/
322 stars 93 forks source link

Added auto-connect feature for easy remote work on startup and "multiple" connections #225

Closed andymule closed 5 years ago

andymule commented 6 years ago

Allows users to save without explicitly connecting to a server. Attempts to match profile names with username parsed from filepath, and if a match is found a connection is opened and the file is uploaded. This enables users to instantly resume working remotely without considering if they're saving files on the server or not.

andymule commented 6 years ago

9dc0b3f might go too far for this initial scope, as it tries to automatically connect to the necessary host for whatever file is saved. but the code is almost identical for the original scope so i think we should go for it

andymule commented 6 years ago

bug: needs to NOT disconnect on local files

andymule commented 6 years ago

@ashkulz Can I get a review on this? Interested in your thoughts.

andymule commented 6 years ago

DLL for testing if interested: https://drive.google.com/file/d/1KfQiVjd1PPl_Ic7Xpkiv_kW699ScoJxi/view?usp=sharing

Just drop into your plugins folder, mine is here: C:\Program Files (x86)\Notepad++\plugins\

chcg commented 6 years ago

You could also find a build at appveyor for some time: x64 https://ci.appveyor.com/project/ashkulz/nppftp/build/0.27.4.58/job/17uho6e0bv7ttg6y/artifacts x32 https://ci.appveyor.com/project/ashkulz/nppftp/build/0.27.4.58/job/yu316rudr8tcchrj/artifacts

@andymule I'm quite sure ashkulz won't step in to have a look at this PR. I could do the merge, but most probably that will not take place before September. So please be patient with me.

andymule commented 6 years ago

Awesome, sounds great. Timeframe seems fine. Would love to get more people testing it out, might blast it onto some related forum posts....

andymule commented 6 years ago

bug: If you quickly save two files on different servers very quickly, it's possible that the first file will be disconnected mid-save

ashkulz commented 6 years ago

I haven't used Windows for 2+ years, so @chcg is the actual maintainer.

@andymule https://github.com/andymule I'm quite sure ashkulz won't step in to have a look at this PR. I could do the merge, but most probably that will not take place before September. So please be patient with me.

chcg commented 6 years ago

@andymule In general the PR looks fine. I think what is still needed is a general option to enable/disable this behaviour to allow the user to decide what he wants. What about the last bug you saw on the two quick saves. "Quick" in this context seems to be related to the connection speed to the server.